[Performance Hints] Disable performance hints if typechecker can skip function bodies #85014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Test |
artemcm
approved these changes
Oct 20, 2025
Contributor
artemcm
left a comment
artemcm
left a comment
There was a problem hiding this comment.
Could you please add a simple lit test which passes in a primary source file and a secondary source file and ensure no diagnostics are emitted for the secondary?
aviralg
force-pushed
the
aviralgoel/performance-hints/ensure-primary-source-file
branch
from
d777ae8 to
dedba4d
Compare
artemcm
approved these changes
Oct 20, 2025
Contributor
Author
|
@swift-ci Test |
aviralg
force-pushed
the
aviralgoel/performance-hints/ensure-primary-source-file
branch
from
dedba4d to
63246b9
Compare
Contributor
Author
|
@swift-ci Test |
Contributor
|
@swift-ci smoke test |
aviralg
force-pushed
the
aviralgoel/performance-hints/ensure-primary-source-file
branch
from
63246b9 to
dbe97e9
Compare
artemcm
approved these changes
Oct 22, 2025
Contributor
|
@swift-ci test |
aviralg
changed the title
…me function bodies If `SkipFunctionBodies` is not `None`, functions that are inlinable or not used for the result are not typechecked. The absence of type information crashes the performance hint analyzer. This change prevents the analyzer from running in these cases.
aviralg
force-pushed
the
aviralgoel/performance-hints/ensure-primary-source-file
branch
from
dbe97e9 to
6a3ca6d
Compare
Contributor
Author
|
@swift-ci test |
Contributor
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SkipFunctionBodiesis notNone, functions that are inlinable or not used for the result are not typechecked. The absence of type information crashes the performance hint analyzer. This change prevents the analyzer from running in these cases.